Forum

Function call:

CExtRibbonPage::RedrawCommandItems( nCmdID );

does not do anything in the RibbonPage example because the toolbar mapping is empty. How to update command items when needed?

Sorry, do you mean that these functions were just added and are not a part of the latest downloadable code (ZIP)?

No, these methods were added to the CExtRibbonPage class immediately before answering your message. They are not inside the latest downloadable source code yet. We are sorry for inconvenience. But they will be statically available in future of course. So, please add them manually or we can provide you with the newer download.

I check it in the sample applicaiton under the debugger. The different function is actually called for CExtRibbonPage::RedrawCommandItems( nCmdID )

INT CExtCustomizeSite::RedrawCommandItems(
    UINT nCmdID,
    bool bUpdateWindows // = true
    ) const
{
    ASSERT( CExtCmdManager::IsCommand(nCmdID) );
INT nUpdateBtnsCount = 0;
    for(    POSITION pos = m_mapToolBars.GetStartPosition();
            pos != NULL;
            )
    {
        CExtToolControlBar * pBar = NULL;
        CToolBarCustomizeInfo * pInfo = NULL;
        m_mapToolBars.GetNextAssoc( pos, (void * &)pBar, (void * &)pInfo );
        ASSERT( pBar != NULL );
        ASSERT( pInfo != NULL );
        if( !pBar->IsVisible() )
            continue;
        INT nBtnsCount = pBar->GetButtonsCount();
        if( nBtnsCount == 0 )
            continue;
        bool bUpdateBar = false;
        for( INT nBtnIdx = 0; nBtnIdx < nBtnsCount; nBtnIdx++ )
        {
            CExtBarButton * pTBB = pBar->GetButton( nBtnIdx );
            ASSERT_VALID( pTBB );
            UINT nTbbCmdID = pTBB->GetCmdID( false );
            if(        nTbbCmdID != nCmdID
                ||    (! pTBB->IsVisible() )
                ||    (pTBB->GetStyle()&TBBS_HIDDEN) != 0
                )
                continue;
            nUpdateBtnsCount ++;
            bUpdateBar = true;
            if( pTBB->IsKindOf(RUNTIME_CLASS(CExtBarColorButton)) )
                ((CExtBarColorButton*)pTBB)->OnSyncIcon();
            pTBB->RedrawButton( false );
        } // for( INT nBtnIdx = 0; nBtnIdx < nBtnsCount; nBtnIdx++ )
        if( bUpdateWindows && bUpdateBar )
            pBar->UpdateWindow();
    }
    return nUpdateBtnsCount;
}

and the m_mapToolBars is empty, so it does not do anything. Note that under the debugger the RedrawCommandItems() method is called from the CExtCustomizeSite class not from the CExtRibbonPage. This is in the standard sample code, I did not make any changes.

We confirm this issue. The following two public methods were added to the CExtRibbonPage class for re-painting and updating ribbon bar’s/ribbon page’s buttons:

      virtual INT RedrawCommandItems(
            UINT nCmdID,
            bool bUpdateWindows = true
            ) const;
      virtual INT UpdateAllCommandItems() const;


INT CExtRibbonPage::RedrawCommandItems(
      UINT nCmdID,
      bool bUpdateWindows // = true
      ) const
{
      ASSERT_VALID( this );
      ASSERT( CExtCmdManager::IsCommand(nCmdID) );
      if( ! IsVisible() )
            return 0;
INT nBtnsCount = GetButtonsCount();
      if( nBtnsCount == 0 )
            return 0;
INT nUpdateBtnsCount = 0;
bool bUpdateBar = false;
      for( INT nBtnIdx = 0; nBtnIdx < nBtnsCount; nBtnIdx++ )
      {
            CExtBarButton * pTBB = ( const_cast < CExtRibbonPage * > ( this ) ) -> GetButton( nBtnIdx );
            ASSERT_VALID( pTBB );
            UINT nTbbCmdID = pTBB->GetCmdID( false );
            if(         nTbbCmdID != nCmdID
                  ||    (! pTBB->IsVisible() )
                  ||    (pTBB->GetStyle()&TBBS_HIDDEN) != 0
                  )
                  continue;
            nUpdateBtnsCount ++;
            bUpdateBar = true;
            if( pTBB->IsKindOf(RUNTIME_CLASS(CExtBarColorButton)) )
                  ((CExtBarColorButton*)pTBB)->OnSyncIcon();
            pTBB->RedrawButton( false );
      } // for( INT nBtnIdx = 0; nBtnIdx < nBtnsCount; nBtnIdx++ )
      if( bUpdateWindows && bUpdateBar )
            ( const_cast < CExtRibbonPage * > ( this ) ) -> UpdateWindow();
      return nUpdateBtnsCount;
}

INT CExtRibbonPage::UpdateAllCommandItems() const
{
      ASSERT_VALID( this );
      if( ! IsVisible() )
            return 0;
      ( const_cast < CExtRibbonPage * > ( this ) ) -> DoCustomModeUpdateCmdUI();
      ( const_cast < CExtRibbonPage * > ( this ) ) -> UpdateWindow();
      return 1;
}